[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/8] disas: m68k: QOMify target specific disas s
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH 3/8] disas: m68k: QOMify target specific disas setup |
Date: |
Sun, 12 Jul 2015 10:43:40 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 |
Le 12/07/2015 04:00, Peter Crosthwaite a écrit :
> From: Peter Crosthwaite <address@hidden>
>
> Move the target_disas() m68k specifics to the QOM disas_set_info hook
> and delete the #ifdef specific code in disas.c.
>
> Cc: Greg Ungerer <address@hidden>
> Cc: Laurent Vivier <address@hidden>
> Signed-off-by: Peter Crosthwaite <address@hidden>
> ---
> Testing:
> I cant find binaries for this arch easily, but I got this from executing
> random code:
>
> $ ./m68k-softmmu/qemu-system-m68k -kernel ./random_code -S -nographic -d
> in_asm 2> err
> QEMU 2.3.90 monitor - type 'help' for more information
> (qemu) xp 0x40000000
> 0000000040000000: 0x7d413a22
> (qemu) xp/i 0x40000000
> 0x40000000: mvsw %d1,%d6
> (qemu) xp/i 0x40000004
> 0x40000004: addqb #2,%a0@(27614)
> (qemu) c
> (qemu) Aborted (core dumped)
>
> $ more err
> qemu: fatal: Illegal instruction: 7d41 @ 40000000
> ---
> disas.c | 4 ----
> target-m68k/cpu.c | 7 +++++++
> 2 files changed, 7 insertions(+), 4 deletions(-)
Reviewed-by: Laurent Vivier <address@hidden>
- [Qemu-devel] [PATCH 0/8] Disas QOMification, round 2, Peter Crosthwaite, 2015/07/11
- [Qemu-devel] [PATCH 1/8] disas: s390x: QOMify target specific disas setup, Peter Crosthwaite, 2015/07/11
- [Qemu-devel] [PATCH 3/8] disas: m68k: QOMify target specific disas setup, Peter Crosthwaite, 2015/07/11
- [Qemu-devel] [PATCH 2/8] disas: moxie: QOMify target specific disas setup, Peter Crosthwaite, 2015/07/11
- [Qemu-devel] [PATCH 4/8] disas: sparc: QOMify target specific disas setup, Peter Crosthwaite, 2015/07/11
- [Qemu-devel] [PATCH 5/8] disas: lm32: QOMify target specific disas setup, Peter Crosthwaite, 2015/07/11
- [Qemu-devel] [PATCH 6/8] disas: sh4: QOMify target specific disas setup, Peter Crosthwaite, 2015/07/11
- [Qemu-devel] [PATCH 7/8] disas: mips: QOMify target specific disas setup, Peter Crosthwaite, 2015/07/11
- [Qemu-devel] [PATCH 8/8] disas: alpha: QOMify target specific disas setup, Peter Crosthwaite, 2015/07/11