qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 7/7] ipxe: update binaries


From: Laszlo Ersek
Subject: Re: [Qemu-devel] [PATCH 7/7] ipxe: update binaries
Date: Wed, 15 Jul 2015 14:58:29 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0

On 07/15/15 14:01, Gerd Hoffmann wrote:
> On Mi, 2015-07-15 at 13:10 +0200, Laszlo Ersek wrote:
>> On 07/15/15 12:10, Gerd Hoffmann wrote:
>>> Signed-off-by: Gerd Hoffmann <address@hidden>
>>> ---
>>>  pc-bios/efi-e1000.rom    | Bin 197120 -> 192512 bytes
>>>  pc-bios/efi-eepro100.rom | Bin 197632 -> 192512 bytes
>>>  pc-bios/efi-ne2k_pci.rom | Bin 195584 -> 190976 bytes
>>>  pc-bios/efi-pcnet.rom    | Bin 195584 -> 190976 bytes
>>>  pc-bios/efi-rtl8139.rom  | Bin 200192 -> 194560 bytes
>>>  pc-bios/efi-virtio.rom   | Bin 194048 -> 188928 bytes
>>>  6 files changed, 0 insertions(+), 0 deletions(-)
>>
>> Shouldn't you also rebuild (well, commit) the non-EFI (ie. pxe-*)
>> binaries too? The rebase in patch #1, the QEMU branding in patch #5, and
>> the now-visible git version from patch #6, all seem to affect the pxe-*
>> binaries as well.
> 
> We didn't do that in the past, because of size problems and because the
> pxe-* versions are only used by old machine types.
> 
> Lets have a look:
> 
>  pc-bios/pxe-e1000.rom    | Bin 67072 -> 62976 bytes
>  pc-bios/pxe-eepro100.rom | Bin 61440 -> 62976 bytes
>  pc-bios/pxe-ne2k_pci.rom | Bin 61440 -> 62464 bytes
>  pc-bios/pxe-pcnet.rom    | Bin 61440 -> 62464 bytes
>  pc-bios/pxe-rtl8139.rom  | Bin 61440 -> 63488 bytes
>  pc-bios/pxe-virtio.rom   | Bin 60416 -> 61952 bytes
> 
> So, the update doesn't work for e1000, where the size goes from > 64k to
> < 64k, which in turn changes the pci rom bar size from 128k to 64k ...

Fair enough, thanks for the background info.

Reviewed-by: Laszlo Ersek <address@hidden>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]