[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V2 3/5] virtio-blk: disable scsi passthrough by
|
From: |
Michael S. Tsirkin |
|
Subject: |
Re: [Qemu-devel] [PATCH V2 3/5] virtio-blk: disable scsi passthrough by default |
|
Date: |
Wed, 15 Jul 2015 17:14:20 +0300 |
On Wed, Jul 15, 2015 at 02:47:24PM +0200, Paolo Bonzini wrote:
>
>
> On 15/07/2015 14:21, Michael S. Tsirkin wrote:
> >> > Disable scsi passthrough by default since it was incompatible with
> >> > virtio 1.0. For legacy machine types, keep this on by default.
> >> >
> >> > Cc: Stefan Hajnoczi <address@hidden>
> >> > Cc: Kevin Wolf <address@hidden>
> >> > Cc: address@hidden
> >> > Signed-off-by: Jason Wang <address@hidden>
> > Seems risky for 2.4. modern is off by default for now. Can't we limit
> > the change to when modern is enabled?
>
> That would have the effect of disabling a feature when you turn on modern.
What's wrong with that?
> > I suggested changing this from bool to on/off/auto, and
> > make auto mean !modern.
>
> No, please do it like Jason did. The SCSI feature effectively had to be
> enabled explicitly already, the requests were marked as unsupported.
>
> Paolo
I didn't know. How is it enabled?
--
MST
[Qemu-devel] [PATCH V2 4/5] virtio-blk: fail the init when both 1.0 and scsi is set, Jason Wang, 2015/07/15
[Qemu-devel] [PATCH V2 5/5] virtio-blk: set VIRTIO_F_ANY_LAYOUT when 1.0 is supported, Jason Wang, 2015/07/15
Re: [Qemu-devel] [PATCH V2 0/5] Set correct blk feature for virtio 1.0, Cornelia Huck, 2015/07/15