[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] xen/pt: Don't slurp wholesale the PCI configura
From: |
Stefano Stabellini |
Subject: |
Re: [Qemu-devel] [PATCH] xen/pt: Don't slurp wholesale the PCI configuration registers |
Date: |
Fri, 17 Jul 2015 17:34:55 +0100 |
User-agent: |
Alpine 2.02 (DEB 1266 2009-07-14) |
On Wed, 8 Jul 2015, Konrad Rzeszutek Wilk wrote:
> Instead we have the emulation registers ->init functions which
> consult the host values to see what the initial value should be
> and they are responsible for populating the dev.config.
>
> Signed-off-by: Konrad Rzeszutek Wilk <address@hidden>
Reviewed-by: Stefano Stabellini <address@hidden>
> hw/xen/xen_pt.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c
> index 05828e0..cd69cb4 100644
> --- a/hw/xen/xen_pt.c
> +++ b/hw/xen/xen_pt.c
> @@ -780,12 +780,7 @@ static int xen_pt_initfn(PCIDevice *d)
> }
>
> /* Initialize virtualized PCI configuration (Extended 256 Bytes) */
> - rc = xen_host_pci_get_block(&s->real_device, 0, d->config,
> - PCI_CONFIG_SPACE_SIZE);
> - if (rc < 0) {
> - XEN_PT_ERR(d,"Could not read PCI_CONFIG space! (rc:%d)\n", rc);
> - goto err_out;
> - }
> + memset(d->config, 0, PCI_CONFIG_SPACE_SIZE);
>
> s->memory_listener = xen_pt_memory_listener;
> s->io_listener = xen_pt_io_listener;
- [Qemu-devel] [PATCH v1 06/10] xen/pt: Log xen_host_pci_get in two init functions, (continued)
- [Qemu-devel] [PATCH v1 06/10] xen/pt: Log xen_host_pci_get in two init functions, Konrad Rzeszutek Wilk, 2015/07/02
- [Qemu-devel] [PATCH v1 05/10] xen/pt: Remove XenPTReg->data field., Konrad Rzeszutek Wilk, 2015/07/02
- [Qemu-devel] [PATCH v1 02/10] xen/pt: Sync up the dev.config and data values., Konrad Rzeszutek Wilk, 2015/07/02
- [Qemu-devel] [PATCH v1 09/10] xen/pt: Move bulk of xen_pt_unregister_device in its own routine., Konrad Rzeszutek Wilk, 2015/07/02
- [Qemu-devel] [PATCH v1 07/10] xen/pt: Log xen_host_pci_get/set errors in MSI code., Konrad Rzeszutek Wilk, 2015/07/02
- [Qemu-devel] [PATCH] Follow-on to Remove XenPTReg->data and use dev.config for guest configuration values., Konrad Rzeszutek Wilk, 2015/07/08