[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL for-2.4 3/7] block/nfs: add support for setting d
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PULL for-2.4 3/7] block/nfs: add support for setting debug level |
Date: |
Tue, 21 Jul 2015 16:37:09 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 07/07/2015 06:08 AM, Stefan Hajnoczi wrote:
> From: Peter Lieven <address@hidden>
>
> upcoming libnfs versions will support logging debug messages. Add
> support for it in qemu through a per-drive option.
>
> Examples:
> qemu -drive if=virtio,file=nfs://...,file.debug=2
> qemu-img create -o debug=2 nfs://... 10G
>
> Signed-off-by: Peter Lieven <address@hidden>
> Reviewed-by: Fam Zheng <address@hidden>
> Message-id: address@hidden
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> block/nfs.c | 28 ++++++++++++++++++++++++----
> qapi/block-core.json | 20 ++++++++++++++++----
> 2 files changed, 40 insertions(+), 8 deletions(-)
>
> +++ b/qapi/block-core.json
> @@ -1381,9 +1381,9 @@
> { 'enum': 'BlockdevDriver',
> 'data': [ 'archipelago', 'blkdebug', 'blkverify', 'bochs', 'cloop',
> 'dmg', 'file', 'ftp', 'ftps', 'host_cdrom', 'host_device',
> - 'host_floppy', 'http', 'https', 'null-aio', 'null-co',
> 'parallels',
> - 'qcow', 'qcow2', 'qed', 'quorum', 'raw', 'tftp', 'vdi', 'vhdx',
> - 'vmdk', 'vpc', 'vvfat' ] }
> + 'host_floppy', 'http', 'https', 'nfs', 'null-aio', 'null-co',
> + 'parallels', 'qcow', 'qcow2', 'qed', 'quorum', 'raw', 'tftp',
> + 'vdi', 'vhdx', 'vmdk', 'vpc', 'vvfat' ] }
Probably also ought to document the docs for BlockDeviceInfo.drv, to
mention that 'nfs' was added in 2.4.
[may be moot for now, since this patch was dropped when the pull request
was resent; or even mean you want "2.5" when you DO add and document it]
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
Re: [Qemu-devel] [PULL for-2.4 3/7] block/nfs: add support for setting debug level,
Eric Blake <=
[Qemu-devel] [PULL for-2.4 4/7] block: Initialize local_err in bdrv_append_temp_snapshot, Stefan Hajnoczi, 2015/07/07
[Qemu-devel] [PULL for-2.4 5/7] block: Use bdrv_drain to replace uncessary bdrv_drain_all, Stefan Hajnoczi, 2015/07/07
[Qemu-devel] [PULL for-2.4 6/7] block/raw-posix: Don't think /dev/fd/<NN> is a floppy drive., Stefan Hajnoczi, 2015/07/07
[Qemu-devel] [PULL for-2.4 7/7] blockjob: add block_job_release function, Stefan Hajnoczi, 2015/07/07