[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/2] block: warn about aio=native if libaio i
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 0/2] block: warn about aio=native if libaio is unavailable |
|
Date: |
Thu, 23 Jul 2015 10:15:14 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 23.07.2015 um 10:08 hat Paolo Bonzini geschrieben:
>
>
> On 23/07/2015 10:03, Markus Armbruster wrote:
> >
> >> > v2:
> >> > * Banish CONFIG_LINUX_AIO from blockdev.c, that is raw-posix.c's
> >> > business
> >> > [Kevin]
> >> > * Print the warning in the same way as the aio=native,cache.direct=off
> >> > deprecation warning [Kevin]
> >> >
> >> > Open question: what about the Windows case? We now pass the
> >> > FILE_FLAG_OVERLAPPED flag which we didn't do before for -drive
> >> > aio=native.
> > Odd. Commit a273652 takes the trouble to implement native asynchronous
> > I/O there, but unless CONFIG_LINUX_AIO somehow gets defined, it's
> > unreachable, isn't it? Paolo?
>
> I don't remember how I tested that code, but it's probably been dead
> code since it was committed. If it's bitrot and thus these patches
> break it, I will fix it.
The tools use a different path, so qemu-img/io would have correctly used
AIO on Windows.
Kevin