Re: [Qemu-devel] [PULL 00/13] Miscellaneous bugfixes for 2.4.0-rc3

[Daniel P. Berrange]

On Fri, Jul 24, 2015 at 02:02:57PM +0200, Paolo Bonzini wrote:
> 
> 
> On 24/07/2015 13:56, Peter Maydell wrote:
> > MALLOC_PERTURB_=${MALLOC_PERTURB_:-$((RANDOM % 255 + 1))} gtester -k
> > --verbose -m=quick tests/test-crypto-cipher
> > TEST: tests/test-crypto-cipher... (pid=94271)
> >   /crypto/cipher/aes-ecb-128:                                          **
> > ERROR:/Users/pm215/src/qemu/tests/test-crypto-cipher.c:279:void
> > test_cipher(const void *): assertion failed (outtexthex ==
> > data->plaintext):
> > ("802829a0f449928641b526a6442d2ecf8f703bdab74810779df19f78ecae4ea9a832ac2abbb3a176ebf4126be9e3d30b32fbac2152e22bd251e11302a368b610"
> > == 
> > "6bc1bee22e409f96e93d7e117393172aae2d8a571e03ac9c9eb76fac45af8e5130c81c46a35ce411e5fbc1191a0a52eff69f2445df4f9b17ad2b417be66c3710")
> > FAIL
> > GTester: last random seed: R02S93f4ba2e4a29fe76a576f8be6fc19678
> > (pid=94272)
> >   /crypto/cipher/aes-ecb-192:                                          **
> > ERROR:/Users/pm215/src/qemu/tests/test-crypto-cipher.c:279:void
> > test_cipher(const void *): assertion failed (outtexthex ==
> > data->plaintext):
> > ("37c547419be0dbb63682f5c0f199361d80c2b4be91bac925d416dd735fe9c40356833e4a660f94658ebd2b857515e1f9cf4bb9727f64105cfaa6185743eb54c2"
> > == 
> > "6bc1bee22e409f96e93d7e117393172aae2d8a571e03ac9c9eb76fac45af8e5130c81c46a35ce411e5fbc1191a0a52eff69f2445df4f9b17ad2b417be66c3710")
> > FAIL
> > GTester: last random seed: R02S9fa2f1bd7fd79de10ee302a8f59ce9b9
> > (pid=94275)
> >   /crypto/cipher/aes-ecb-256:                                          **
> > ERROR:/Users/pm215/src/qemu/tests/test-crypto-cipher.c:279:void
> > test_cipher(const void *): assertion failed (outtexthex ==
> > data->plaintext):
> > ("b7ad7fa1b13a51d8ee2bd0c1329d575c6a73594b0387c40e078d445e0b8897c2f1ccaf178a0fc46e01d79809d758d144b0dc02874c1abcfad153575e8de48eae"
> > == 
> > "6bc1bee22e409f96e93d7e117393172aae2d8a571e03ac9c9eb76fac45af8e5130c81c46a35ce411e5fbc1191a0a52eff69f2445df4f9b17ad2b417be66c3710")
> > FAIL
> > GTester: last random seed: R02S1b0f9159aaa37c711bedfd80192ca4f5
> > (pid=94276)
> >   /crypto/cipher/aes-cbc-128:                                          **
> > ERROR:/Users/pm215/src/qemu/tests/test-crypto-cipher.c:279:void
> > test_cipher(const void *): assertion failed (outtexthex ==
> > data->plaintext):
> > ("46e335b8ea11bcc5b4eb7f49d114ff43282215ad3acff16be19b6f711aa13b8969fd9fb7982a3703e816143f8962560fda85ad94d34e54182a525c2b28fa0eab"
> > == 
> > "6bc1bee22e409f96e93d7e117393172aae2d8a571e03ac9c9eb76fac45af8e5130c81c46a35ce411e5fbc1191a0a52eff69f2445df4f9b17ad2b417be66c3710")
> > FAIL
> > GTester: last random seed: R02S47c21805c19462cf111f4c9a790663ba
> > (pid=94277)
> >   /crypto/cipher/aes-cbc-192:                                          **
> > ERROR:/Users/pm215/src/qemu/tests/test-crypto-cipher.c:279:void
> > test_cipher(const void *): assertion failed (outtexthex ==
> > data->plaintext):
> > ("80d40e64bd09da15f62c5d2dca6b21e3f35430b68fc5decd37d4c3fade1c5447e435ab7965e648fb53c7c802c9576fdcf49923a267c19498d8a6a53ee6d49643"
> > == 
> > "6bc1bee22e409f96e93d7e117393172aae2d8a571e03ac9c9eb76fac45af8e5130c81c46a35ce411e5fbc1191a0a52eff69f2445df4f9b17ad2b417be66c3710")
> > FAIL
> > GTester: last random seed: R02Sae1928fd64a524afb86c99c0f0ef89b6
> > (pid=94280)
> >   /crypto/cipher/aes-cbc-256:                                          **
> > ERROR:/Users/pm215/src/qemu/tests/test-crypto-cipher.c:279:void
> > test_cipher(const void *): assertion failed (outtexthex ==
> > data->plaintext):
> > ("ce054cfa6ec264de70202e906bd57065101da549b984ee26af6e06ef80fe30b3493431a21454391ac11a1ff5dc0414b607d932eaec0446521c3ebb52b7d38f4c"
> > == 
> > "6bc1bee22e409f96e93d7e117393172aae2d8a571e03ac9c9eb76fac45af8e5130c81c46a35ce411e5fbc1191a0a52eff69f2445df4f9b17ad2b417be66c3710")
> > FAIL
> > GTester: last random seed: R02Sf28d8a242b89a287745d6b8ea3a431d7
> > (pid=94281)
> >   /crypto/cipher/des-rfb-ecb-56:                                       OK
> > FAIL: tests/test-crypto-cipher
> > 
> > -- PMM
> > 
> 
> I'll respin without this patch.  I can reproduce it with
> --disable-gnutls.  Dan, can you take a look?

So this patch was not actually causing the problem, merely exposing a
latent bug. I've just sent a fix for the root cause, which you can
queue before the test case patch addition to preserve bisectability.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|