[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for 2.4 1/3] net/dp8393x: disable user creation
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH for 2.4 1/3] net/dp8393x: disable user creation |
Date: |
Sun, 26 Jul 2015 22:11:03 +0200 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On 2015-07-24 20:42, Hervé Poussineau wrote:
> Netcard needs an address space to write data to, which can't be specified on
> command line.
> This fixes a crash when user starts QEMU with "-device dp8393x"
>
> Signed-off-by: Hervé Poussineau <address@hidden>
> ---
> hw/net/dp8393x.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c
> index cd889bc..8fafdb0 100644
> --- a/hw/net/dp8393x.c
> +++ b/hw/net/dp8393x.c
> @@ -881,6 +881,8 @@ static void dp8393x_class_init(ObjectClass *klass, void
> *data)
> dc->reset = dp8393x_reset;
> dc->vmsd = &vmstate_dp8393x;
> dc->props = dp8393x_properties;
> + /* Reason: dma_mr property can't be set */
> + dc->cannot_instantiate_with_device_add_yet = true;
> }
>
> static const TypeInfo dp8393x_info = {
Reviewed-by: Aurelien Jarno <address@hidden>
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
address@hidden http://www.aurel32.net