Re: [Qemu-devel] [PATCH v7 18/42] Add wrappers and handlers for sending/receiving the postcopy-ram migration messages.

[Dr. David Alan Gilbert]

* Amit Shah (address@hidden) wrote:
> On (Tue) 16 Jun 2015 [11:26:31], Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert" <address@hidden>
> > 
> > The state of the postcopy process is managed via a series of messages;
> >    * Add wrappers and handlers for sending/receiving these messages
> >    * Add state variable that track the current state of postcopy
> > 
> > Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> 
> Reviewed-by: Amit Shah <address@hidden>

Thanks,

> But:
> 
> > +void qemu_savevm_send_postcopy_ram_discard(QEMUFile *f, const char *name,
> > +                                           uint16_t len,
> > +                                           uint64_t *start_list,
> > +                                           uint64_t *end_list)
> > +{
> > +    uint8_t *buf;
> > +    uint16_t tmplen;
> > +    uint16_t t;
> > +    size_t name_len = strlen(name);
> > +
> > +    trace_qemu_savevm_send_postcopy_ram_discard(name, len);
> > +    buf = g_malloc0(len*16 + name_len + 3);
> > +    buf[0] = 0; /* Version */
> > +    assert(name_len < 256);
> > +    buf[1] = name_len;
> > +    memcpy(buf+2, name, name_len);
> > +    tmplen = 2+name_len;
> > +    buf[tmplen++] = '\0';
> 
> whitespace around operators missing
> 
> > +static int loadvm_postcopy_ram_handle_discard(MigrationIncomingState *mis,
> > +                                              uint16_t len)
> 
> > +    len -= 3+strlen(ramid);
> 
> ditto

Fixed.

Dave

> 
>               Amit
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK