[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] vhost-scsi: Fix mask index err in vhost_scsi_st
|
From: |
Gonglei |
|
Subject: |
Re: [Qemu-devel] [PATCH] vhost-scsi: Fix mask index err in vhost_scsi_start |
|
Date: |
Mon, 27 Jul 2015 19:11:54 +0800 |
|
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 2015/7/27 18:20, Paolo Bonzini wrote:
>
>
> On 27/07/2015 08:25, address@hidden wrote:
>> +++ b/hw/scsi/vhost-scsi.c
>> @@ -117,7 +117,7 @@ static int vhost_scsi_start(VHostSCSI *s)
>> * enabling/disabling irqfd.
>> */
>> for (i = 0; i < s->dev.nvqs; i++) {
>> - vhost_virtqueue_mask(&s->dev, vdev, i, false);
>> + vhost_virtqueue_mask(&s->dev, vdev, s->dev.vq_index + i, false);
>> }
>>
>> return ret;
>
> Is this fixing an actual bug, or just using the API correctly?
> s->dev.vq_index is always 0, right?
>
Yes. At present, we found that s->dev.vq_index is always 0.
Regards,
-Gonglei