[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC v2 35/47] qapi-commands: Rearrange code
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH RFC v2 35/47] qapi-commands: Rearrange code |
Date: |
Tue, 28 Jul 2015 11:18:56 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 07/01/2015 02:22 PM, Markus Armbruster wrote:
>> Rename gen_marshal_input() to gen_marshal(), because the generated
>> function marshals both arguments and results.
>>
>> Rename gen_visitor_input_containers_decl() to gen_marshal_vars(), and
>> move the other variable declarations there, too.
>>
>> Rename gen_visitor_input_block()() to gen_marshal_input_visit(), and
>
> Double ().
Will fix.
>> rearrange its code slightly.
>>
>> Rename gen_marshal_input_decl() to gen_marshal_proto(), because the
>> result isn't a full declaration, unlike gen_command_decl()'s.
>>
>> New gen_marshal_decl() actually returns a full declaration.
>
> No change to generated code; good.
>
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>> scripts/qapi-commands.py | 95
>> ++++++++++++++++++++++--------------------------
>> 1 file changed, 43 insertions(+), 52 deletions(-)
>>
>
>> push_indent()
>> +
>> + if rets:
>> + # FIXME fishy: only pointers are initialized
>> + if rets.c_null() == 'NULL':
>> + retval = '%s retval = NULL;' % rets.c_type()
>> + else:
>> + retval = '%s retval;' % rets.c_type()
>
> May still need tweaking based on my earlier reviews.
Yes, this part should go away.
> Reviewed-by: Eric Blake <address@hidden>
Thanks!
- Re: [Qemu-devel] [PATCH RFC v2 43/47] qmp: Improve netdev_add usage example in the manual, (continued)
- [Qemu-devel] [PATCH RFC v2 42/47] qapi-schema: Fix up misleading specification of netdev_add, Markus Armbruster, 2015/07/01
- [Qemu-devel] [PATCH RFC v2 46/47] qapi-introspect: Map all integer types to 'int', Markus Armbruster, 2015/07/01
- [Qemu-devel] [PATCH RFC v2 39/47] qapi: Improve built-in type documentation, Markus Armbruster, 2015/07/01
- [Qemu-devel] [PATCH RFC v2 35/47] qapi-commands: Rearrange code, Markus Armbruster, 2015/07/01
- [Qemu-devel] [PATCH RFC v2 21/47] qapi: New QAPISchema intermediate reperesentation, Markus Armbruster, 2015/07/01
- [Qemu-devel] [PATCH RFC v2 47/47] qapi-introspect: Hide type names, Markus Armbruster, 2015/07/01