[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 02/45] msix: add VMSTATE_MSIX_TEST
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2 02/45] msix: add VMSTATE_MSIX_TEST |
Date: |
Wed, 29 Jul 2015 09:41:50 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 |
On 28/07/2015 02:32, Marc-André Lureau wrote:
> From: Marc-André Lureau <address@hidden>
>
> ivshmem is going to use MSIX state conditionally.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> include/hw/pci/msix.h | 16 ++++++++++------
> 1 file changed, 10 insertions(+), 6 deletions(-)
>
> diff --git a/include/hw/pci/msix.h b/include/hw/pci/msix.h
> index 954d82b..72e5f93 100644
> --- a/include/hw/pci/msix.h
> +++ b/include/hw/pci/msix.h
> @@ -46,12 +46,16 @@ void msix_unset_vector_notifiers(PCIDevice *dev);
>
> extern const VMStateDescription vmstate_msix;
>
> -#define VMSTATE_MSIX(_field, _state) { \
> - .name = (stringify(_field)), \
> - .size = sizeof(PCIDevice), \
> - .vmsd = &vmstate_msix, \
> - .flags = VMS_STRUCT, \
> - .offset = vmstate_offset_value(_state, _field, PCIDevice), \
> +#define VMSTATE_MSIX_TEST(_field, _state, _test) { \
> + .name = (stringify(_field)), \
> + .size = sizeof(PCIDevice), \
> + .vmsd = &vmstate_msix, \
> + .flags = VMS_STRUCT, \
> + .offset = vmstate_offset_value(_state, _field, PCIDevice), \
> + .field_exists = (_test) \
> }
>
> +#define VMSTATE_MSIX(_f, _s) \
> + VMSTATE_MSIX_TEST(_f, _s, NULL)
> +
> #endif
>
Why can't it be saved unconditionally?
Paolo
[Qemu-devel] [PATCH v2 03/45] ivhsmem: read do not accept more than sizeof(long), Marc-André Lureau, 2015/07/27
[Qemu-devel] [PATCH v2 04/45] ivshmem: fix number of bytes to push to fifo, Marc-André Lureau, 2015/07/27
[Qemu-devel] [PATCH v2 05/45] ivshmem: factor out the incoming fifo handling, Marc-André Lureau, 2015/07/27