qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 11/12] filter/buffer: add an interval option to


From: Yang Hongyang
Subject: Re: [Qemu-devel] [PATCH 11/12] filter/buffer: add an interval option to buffer filter
Date: Thu, 30 Jul 2015 17:12:53 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0



On 07/30/2015 04:53 PM, Jason Wang wrote:


On 07/30/2015 01:37 PM, Yang Hongyang wrote:
Hi Jason,

   Thank you for review!

On 07/30/2015 01:27 PM, Jason Wang wrote:


On 07/29/2015 06:51 PM, Yang Hongyang wrote:
the buffer filter will release packets by interval.

Signed-off-by: Yang Hongyang <address@hidden>

Looks liked it's better to squash this patch into the buffer?

I don't know if it's better...but if it brings inconvenience to the
reviewers, I will squash it in the next version.


Please do this.

Ok.


And should
we stop the timer during vm stop?

The timer group is QEMU_CLOCK_VIRTUAL, so the timer should be
automatically
stopped during vm stop.

  * @QEMU_CLOCK_VIRTUAL: virtual clock
  *
  * The virtual clock is only run during the emulation. It is stopped
  * when the virtual machine is stopped. Virtual timers use a high
  * precision clock, usually cpu cycles (use ticks_per_sec).


I see, but I don't get why it should be a virtual clock? It has nothing
to do with guest.

It has, it buffers the guest output packets, if the guest is stopped, there
should be no packets sent from guest. So make the timer a virtual clock
ought to be reasonable...


.


--
Thanks,
Yang.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]