qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH 12.5/47] qapi: Document that input visitor s


From: Markus Armbruster
Subject: Re: [Qemu-devel] [RFC PATCH 12.5/47] qapi: Document that input visitor semantics are prone to leaks
Date: Fri, 31 Jul 2015 11:50:02 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Eric Blake <address@hidden> writes:

> Most functions that can return a pointer or set an Error ** value
> are decent enough to guarantee a NULL return when reporting an error.
> Not so with our generated qapi visitor functions.  If the caller
> is not careful to clean up partially-allocated objects on error,
> then the caller suffers a memory leak.
>
> Properly fixing it is probably complex enough to save for a later
> day, so merely document it for now.
>
> Signed-off-by: Eric Blake <address@hidden>

Picked into my series.  Thanks!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]