qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 1/5] cpu: Provide vcpu throttling interface


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v4 1/5] cpu: Provide vcpu throttling interface
Date: Sat, 1 Aug 2015 11:40:47 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0


On 31/07/2015 20:11, Jason J. Herne wrote:
>>>
>>
>> Doh! Yep :). This problem is an artifact of moving the timer_mod from
>> cpu_throttle_thread into cpu_throttle_timer_tick. I'll have to go back
>> to the review comments and look at why that was done.
> 
> So, we made that change in v3 to eliminate the per cpu timer. With a per
> cpu timer we avoid this problem and we no longer need to worry about
> a throttle_thread_scheduled, and timers stacking. Paolo, you had originally
> argued in favor of this change. With what we know now, do you still think
> having only a single timer is best? Or should I switch back to a timer per
> cpu? With a timer per cpu we can simply reset the timer immediately after
> the sleep.

It's okay to have a single timer, only the formulas have to be
corrected: either you remove the pct/(1-pct) from the callback or you
add a /(1-pct) to the timer_mod.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]