[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.4 0/3] Migration regressions with Xen.
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH for-2.4 0/3] Migration regressions with Xen. |
Date: |
Mon, 3 Aug 2015 09:36:00 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
* Amit Shah (address@hidden) wrote:
> On (Fri) 31 Jul 2015 [10:59:47], Stefano Stabellini wrote:
> > On Thu, 30 Jul 2015, Stefano Stabellini wrote:
> > > On Thu, 30 Jul 2015, Juan Quintela wrote:
> > > > Anthony PERARD <address@hidden> wrote:
> > > > > This is a critical issue for Xen as migration either with the same
> > > > > version
> > > > > of QEMU, or from a previous version of QEMU is broken.
> > > > >
> > > > > Any suggestion on how to move forward?
> > > >
> > > > Will send a pull requset tomorrow.
> > > >
> > > > Thinking about creating a single function that is called for all needed
> > > > places, just to avoid this problem in the future.
> > > >
> > >
> > > Hi Juan,
> > >
> > > thanks for looking into this!
> > > Do you have patches already we can look at and help you test to make
> > > sure they fix the issue?
> >
> > Any updates?
>
> That bigger overhaul would be 2.5 stuff now.
>
> The only thing that tripped here was the RFC tag in the subject line.
>
> Also, I think Dave had a comment about this but I think that was made
> on IRC. Dave, do you see a problem with this series?
Most of it is in Xen only code, so mostly no, however, the followign code looks
wrong to me:
+void global_state_store_running(void)
+{
+ const char *state = RunState_lookup[RUN_STATE_RUNNING];
+ memcpy((char *)global_state.runstate,
+ state, sizeof(global_state.runstate));
+}
Shouldn't that just be a strcpy ?
Dave
> Thanks,
>
>
> Amit
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK