[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 6/9] vhost: use variable arguments for vhost_
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH v2 6/9] vhost: use variable arguments for vhost_call() |
Date: |
Mon, 3 Aug 2015 13:03:14 +0200 |
Hi
On Sat, Aug 1, 2015 at 4:47 AM, <address@hidden> wrote:
>> diff --git a/hw/virtio/vhost-backend.c b/hw/virtio/vhost-backend.c
>> index 4d68a27..7255089 100644
>> --- a/hw/virtio/vhost-backend.c
>> +++ b/hw/virtio/vhost-backend.c
>> @@ -14,8 +14,8 @@
>>
>> #include <sys/ioctl.h>
>>
>> -static int vhost_kernel_call(struct vhost_dev *dev, unsigned long int
>> request,
>> - void *arg)
>> +static int vhost_kernel_call(struct vhost_dev *dev,
>> + unsigned long int request, void *arg, ...)
>
>
>
> I Couldn't see in your set where you change vhost_kernel_call()
> implementation or
> make any use of this change.
>
That's expected, the change is necessary for vhost-user only atm. They both use
the same callback, so vhost-kernel must be changed too and ignore the
extra args.
cheers
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v2 6/9] vhost: use variable arguments for vhost_call(),
Marc-André Lureau <=