[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.4 v3 3/3] migration: Fix regression for xe
From: |
Stefano Stabellini |
Subject: |
Re: [Qemu-devel] [PATCH for-2.4 v3 3/3] migration: Fix regression for xenfv and pc, accel=xen machine. |
Date: |
Mon, 3 Aug 2015 15:53:10 +0100 |
User-agent: |
Alpine 2.02 (DEB 1266 2009-07-14) |
On Mon, 3 Aug 2015, Anthony PERARD wrote:
> This fix migration from the same QEMU version and from previous QEMU
> version.
>
> >From the global state section, we don't need runstate with Xen. Right now,
> the way the Xen toolstack knows when QEMU is ready is when QEMU reach
> "running" runstate.
>
> The configuration section and the section footers are not going to be
> present in previous version of QEMU with xenfv machine, so we skip them.
>
> The Xen toolstack libxenlight does not specify a particular version of the
> 'pc' machine, so migration from older version of QEMU used by Xen to newer
> one would break due to missing "configuration" section and section footers.
>
> Signed-off-by: Anthony PERARD <address@hidden>
Reviewed-by: Stefano Stabellini <address@hidden>
> xen-common.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/xen-common.c b/xen-common.c
> index 56359ca..0dcdbc3 100644
> --- a/xen-common.c
> +++ b/xen-common.c
> @@ -12,6 +12,7 @@
> #include "qmp-commands.h"
> #include "sysemu/char.h"
> #include "sysemu/accel.h"
> +#include "migration/migration.h"
>
> //#define DEBUG_XEN
>
> @@ -119,6 +120,10 @@ static int xen_init(MachineState *ms)
> }
> qemu_add_vm_change_state_handler(xen_change_state_handler, NULL);
>
> + global_state_set_optional();
> + savevm_skip_configuration();
> + savevm_skip_section_footers();
> +
> return 0;
> }
>
> --
> Anthony PERARD
>
- [Qemu-devel] [PATCH for-2.4 v3 0/3] Migration regressions with Xen., Anthony PERARD, 2015/08/03
- [Qemu-devel] [PATCH for-2.4 v3 3/3] migration: Fix regression for xenfv and pc, accel=xen machine., Anthony PERARD, 2015/08/03
- Re: [Qemu-devel] [PATCH for-2.4 v3 3/3] migration: Fix regression for xenfv and pc, accel=xen machine.,
Stefano Stabellini <=
- [Qemu-devel] [PATCH for-2.4 v3 2/3] migration: Add configuration section to vmstate with xen., Anthony PERARD, 2015/08/03
- [Qemu-devel] [PATCH for-2.4 v3 1/3] migration: Fix global state with Xen., Anthony PERARD, 2015/08/03
- Re: [Qemu-devel] [PATCH for-2.4 v3 0/3] Migration regressions with Xen., Amit Shah, 2015/08/03