[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/2] make: load only required dependency file
|
From: |
Victor kaplansky |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 2/2] make: load only required dependency files. |
|
Date: |
Wed, 5 Aug 2015 21:22:09 +0300 |
On Wed, Aug 05, 2015 at 07:40:00PM +0200, Paolo Bonzini wrote:
>
>
> On 05/08/2015 19:29, Victor Kaplansky wrote:
> > diff --git a/hw/i386/Makefile.objs b/hw/i386/Makefile.objs
> > index bd4f147..311d364 100644
> > --- a/hw/i386/Makefile.objs
> > +++ b/hw/i386/Makefile.objs
> > @@ -10,6 +10,8 @@ obj-y += acpi-build.o
> > hw/i386/acpi-build.o: hw/i386/acpi-build.c \
> > hw/i386/acpi-dsdt.hex hw/i386/q35-acpi-dsdt.hex
> >
> > +-include hw/i386/acpi-dsdt.d hw/i386/q35-acpi-dsdt.d
> > +
>
> Having to include the files manually is ugly though.
>
> The failed builds are ugly too, but I'm not sure which is worse... :(
> Failed builds happen rarely and there are other cases where you should
> just "make distclean" your way out of a failure. On the other hand,
> more complicated makefiles have to be maintained always.
Actually there is no problem to keep the list of generated *.hex targets
as we do for *.o objects. Just current list is very short, only two
items, so I leaved them as is.
--Victor