[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 21/26] qapi: Command returning anonymous type do
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 21/26] qapi: Command returning anonymous type doesn't work, outlaw |
Date: |
Thu, 06 Aug 2015 07:43:34 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 08/04/2015 11:29 PM, Markus Armbruster wrote:
>> Eric Blake <address@hidden> writes:
>>
>>> On 08/04/2015 03:18 AM, Markus Armbruster wrote:
>>>> Reproducer: with
>>>>
>>>> { 'command': 'user_def_cmd4', 'returns': { 'a': 'int' } }
>>>>
>>>> added to qapi-schema-test.json, qapi-commands.py dies when it tries to
>>>> generate the command handler function
>>>>
>
>>> +++ w/tests/qapi-schema/command-int.json
>>> @@ -1,3 +1,4 @@
>>> # we reject collisions between commands and types
>>> { 'command': 'int', 'data': { 'character': 'str' },
>>> - 'returns': { 'value': 'int' } }
>>> + 'returns': 'Foo' }
>>> +{ 'struct': 'Foo', 'data': { 'value': 'int' } }
>>
>> Okay to simply drop the 'returns' instead?
>>
>
> Sure, that works too.
Done, with commit message amended:
Simply outlaw this usage, and drop or dumb down test cases accordingly.
- [Qemu-devel] [PATCH 22/26] qapi-commands: Fix gen_err_check(e) for e and e != 'local_err', (continued)
- [Qemu-devel] [PATCH 22/26] qapi-commands: Fix gen_err_check(e) for e and e != 'local_err', Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH 26/26] qapi: Generated code cleanup, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH 18/26] tests/qapi-schema: Rename tests from data- to args-, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH 24/26] qapi-commands: Don't feed output of mcgen() to mcgen() again, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH 21/26] qapi: Command returning anonymous type doesn't work, outlaw, Markus Armbruster, 2015/08/04