Re: [Qemu-devel] [PATCH RFC v3 10/32] qapi-types: Convert to QAPISchemaVisitor, fixing flat unions

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> On 08/04/2015 09:57 AM, Markus Armbruster wrote:
>> Fixes flat unions to get the base's base members.  Test case is from
>> commit 2fc0043, in qapi-schema-test.json:
>> 
>
>> 
>> Flat union visitors remain broken.  They'll be fixed next.
>> 
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>>  docs/qapi-code-gen.txt                  |  51 +++---
>
> Thanks for updating the docs. The diffstat of the actual generated code
> is large, but the extra commits prove that in the end it's the same
> material, just in different ordering.  Meanwhile, the doc example is
> correct, and being much shorter, makes it easier to see the sort of
> reordering that happened.
>
>>  scripts/qapi-types.py                   | 273 
>> ++++++++++++++------------------
>>  tests/qapi-schema/qapi-schema-test.json |   4 +-
>>  3 files changed, 144 insertions(+), 184 deletions(-)
>> 
>
>> +
>> +# If you link code generated from multiple schemata, you want only one
>> +# instance include the code generated for built-in types.  Generate it
>
> s/include/of/

Both phrasings parse fine for me :)

Yours: you want it generated just once.

Mine: you want only one generated instance include the code for built-in
types.

I'll go with "you want only one instance of the code for built-in
types."

>> +# only when do_builtins, enabled by command line option -b.  See also
>> +# QAPISchemaGenTypeVisitor.visit_end().
>>  do_builtins = False
>
> With the grammar fix,
>
> Reviewed-by: Eric Blake <address@hidden>

Thanks!