[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/2] fw_cfg: document MMIO registers for arm,
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/2] fw_cfg: document MMIO registers for arm, sun4*, and ppc/mac_* |
Date: |
Thu, 6 Aug 2015 11:14:25 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 08/06/15 01:47, Gabriel L. Somlo wrote:
> Signed-off-by: Gabriel Somlo <address@hidden>
> ---
> docs/specs/fw_cfg.txt | 22 +++++++++++++++++++---
> 1 file changed, 19 insertions(+), 3 deletions(-)
>
> diff --git a/docs/specs/fw_cfg.txt b/docs/specs/fw_cfg.txt
> index 5bc7b96..f37e1ad 100644
> --- a/docs/specs/fw_cfg.txt
> +++ b/docs/specs/fw_cfg.txt
> @@ -72,10 +72,26 @@ increasing address order, similar to memcpy().
>
> == Register Locations ==
>
> -=== x86, x86_64 Register Locations ===
> +=== x86, x86_64, sun4u Register Locations ===
> +
> +Selector Register IOport: 0x510 (16-bit, little-endian)
> +Data Register IOport: 0x511 (8-bit)
> +
> +=== arm Register Locations ===
> +
> +Selector Register MMIO addr: 0x9020008 (16-bit, big-endian)
> +Data Register MMIO addr: 0x9020000 (64-bit)
Suggestions:
- maybe mention that this is specific to the "virt" machtype
- mention that the exact location comes from the DTB,
and hint at "Documentation/devicetree/bindings/arm/fw-cfg.txt" in the
kernel tree
- for the data register, rather than just "(64-bit)", consider saying
"(64-bit, endianless, string-preserving)"
> +
> +=== sun4m Register Locations ===
> +
> +Selector Register MMIO addr: 0xd00000510 (16-bit, big-endian)
> +Data Register MMIO addr: 0xd00000512 (8-bit)
> +
> +=== ppc/mac Register Locations ===
> +
> +Selector Register MMIO addr: 0xf0000510 (16-bit, big-endian)
> +Data Register MMIO addr: 0xf0000512 (8-bit)
Should these be tied to machine types? (I got no clue, I've never even
built these targets.)
Thanks
Laszlo
>
> -Selector Register IOport: 0x510
> -Data Register IOport: 0x511
>
> == Firmware Configuration Items ==
>
>
- [Qemu-devel] [PATCH v2 0/2] fw_cfg: documentation updates for v2.4, Gabriel L. Somlo, 2015/08/05
- [Qemu-devel] [PATCH v2 1/2] fw_cfg: document fw_cfg_modify_iXX() update functions, Gabriel L. Somlo, 2015/08/05
- [Qemu-devel] [PATCH v2 2/2] fw_cfg: document MMIO registers for arm, sun4*, and ppc/mac_*, Gabriel L. Somlo, 2015/08/05
- Re: [Qemu-devel] [PATCH v2 2/2] fw_cfg: document MMIO registers for arm, sun4*, and ppc/mac_*,
Laszlo Ersek <=
- Re: [Qemu-devel] [PATCH v2 2/2] fw_cfg: document MMIO registers for arm, sun4*, and ppc/mac_*, Peter Maydell, 2015/08/06
- Re: [Qemu-devel] [PATCH v2 2/2] fw_cfg: document MMIO registers for arm, sun4*, and ppc/mac_*, Gabriel L. Somlo, 2015/08/06
- Re: [Qemu-devel] [PATCH v2 2/2] fw_cfg: document MMIO registers for arm, sun4*, and ppc/mac_*, Peter Maydell, 2015/08/06
Re: [Qemu-devel] [PATCH v2 0/2] fw_cfg: documentation updates for v2.4, Peter Maydell, 2015/08/06