Re: [Qemu-devel] [PATCH v8 3/5] Introduce irqchip type specification for KVM

[Pavel Fedin]

 Hello!

> I still think this is the wrong approach -- see my remarks
> in the previous round of patch review.

 You know... I thought a little bit...
 So far, test = true in KVM_CREATE_DEVICE means that we just want to know 
whether this type is supported. No actual actions is done by the kernel. Is it 
correct? If yes, we can just leave this test as it is, because if it says that 
GICv2 is supported by KVM_CREATE_DEVICE, then:
1. We use new API. No KVM_IRQCHIP_CREATE.
2. GICv3 may be supported.

 Therefore, if we do this check, and it succeeds, then we just proceed, and 
later actually try to create GICv3. If it fails for some reason, we will see 
error message anyway. So would it be OK just not to touch 
kvm_arch_irqchip_create() at all?

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia