[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.5 23/30] m68k: add linkl
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH for-2.5 23/30] m68k: add linkl |
Date: |
Wed, 12 Aug 2015 10:33:39 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 08/09/2015 01:13 PM, Laurent Vivier wrote:
> Signed-off-by: Laurent Vivier <address@hidden>
> ---
> target-m68k/translate.c | 21 +++++++++++++++++++--
> 1 file changed, 19 insertions(+), 2 deletions(-)
>
> diff --git a/target-m68k/translate.c b/target-m68k/translate.c
> index 9a7558a..95d58d1 100644
> --- a/target-m68k/translate.c
> +++ b/target-m68k/translate.c
> @@ -1789,8 +1789,24 @@ DISAS_INSN(link)
> TCGv reg;
> TCGv tmp;
>
> - offset = cpu_ldsw_code(env, s->pc);
> - s->pc += 2;
> + offset = read_im16(env, s);
> + reg = AREG(insn, 0);
> + tmp = tcg_temp_new();
> + tcg_gen_subi_i32(tmp, QREG_SP, 4);
> + gen_store(s, OS_LONG, tmp, reg);
> + if ((insn & 7) != 7) {
> + tcg_gen_mov_i32(reg, tmp);
> + }
> + tcg_gen_addi_i32(QREG_SP, tmp, offset);
> +}
> +
> +DISAS_INSN(linkl)
> +{
> + int32_t offset;
> + TCGv reg;
> + TCGv tmp;
> +
> + offset = read_im32(env, s);
> reg = AREG(insn, 0);
> tmp = tcg_temp_new();
> tcg_gen_subi_i32(tmp, QREG_SP, 4);
Surely you can share most of the code via a subroutine,
since the only difference is the size of the immediate.
> @@ -3179,6 +3195,7 @@ void register_m68k_insns (CPUM68KState *env)
> INSN(not, 4600, ff00, M68000);
> INSN(undef, 46c0, ffc0, M68000);
> INSN(move_to_sr, 46c0, ffc0, CF_ISA_A);
> + INSN(linkl, 4808, fff8, M68000);
> INSN(pea, 4840, ffc0, CF_ISA_A);
> INSN(pea, 4840, ffc0, M68000);
> INSN(swap, 4840, fff8, CF_ISA_A);
>
- Re: [Qemu-devel] [PATCH for-2.5 21/30] m68k: add bkpt, (continued)
- [Qemu-devel] [PATCH for-2.5 19/30] m68k: add cmpm, Laurent Vivier, 2015/08/09
- [Qemu-devel] [PATCH for-2.5 25/30] m68k: add abcd, sbcd, nbcd instructions, Laurent Vivier, 2015/08/09
- [Qemu-devel] [PATCH for-2.5 24/30] m68k: add DBcc and Scc (memory operand), Laurent Vivier, 2015/08/09
- [Qemu-devel] [PATCH for-2.5 22/30] m68k: add cas instruction, Laurent Vivier, 2015/08/09
- [Qemu-devel] [PATCH for-2.5 23/30] m68k: add linkl, Laurent Vivier, 2015/08/09
- Re: [Qemu-devel] [PATCH for-2.5 23/30] m68k: add linkl,
Richard Henderson <=
- [Qemu-devel] [PATCH for-2.5 27/30] m68k: add addx/subx/negx, Laurent Vivier, 2015/08/09
- [Qemu-devel] [PATCH for-2.5 28/30] m68k: shift/rotate bytes and words, Laurent Vivier, 2015/08/09
- [Qemu-devel] [PATCH for-2.5 26/30] m68k: add mull/divl, Laurent Vivier, 2015/08/09
- [Qemu-devel] [PATCH for-2.5 29/30] m68k: add rol/rox/ror/roxr, Laurent Vivier, 2015/08/09