[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 1/3] ahci: Separate the AHCI state structure
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v1 1/3] ahci: Separate the AHCI state structure into the header |
Date: |
Sat, 15 Aug 2015 22:57:12 +0100 |
On 15 August 2015 at 22:18, Peter Crosthwaite
<address@hidden> wrote:
> This has come up a few times, and the conclusion was to do the
> inlining by preference. I vaguely remember PMM started an effort to
> build infrastructure to hide the internals from use by outsiders, but
> the struct def is desirable for the inlining even if the internals are
> private a different module.
The idea was just to mark up the fields which are supposed
to be private to the implementation, so everybody can use
the same header, but outsiders get a warning/error if they
try to touch things they shouldn't.
https://lists.gnu.org/archive/html/qemu-devel/2014-05/msg01846.html
I should probably get back to that at some point -- Paolo
had an interesting suggestion involving some cpp macros
which I never got round to investigating.
thanks
-- PMM