qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 21/25] audio: common rate control code for timer


From: Marc-André Lureau
Subject: Re: [Qemu-devel] [PATCH 21/25] audio: common rate control code for timer based outputs
Date: Fri, 21 Aug 2015 00:37:55 +0200

Hi

On Thu, Aug 6, 2015 at 8:28 PM, Kővágó, Zoltán <address@hidden> wrote:
>
> -    decr = rate_get_samples(&hw->info, &out->rate);
> -    decr = audio_MIN(out->fsize - out->fpos, decr);
> -
> -    *size = decr << 2;
> +    *size = audio_rate_get_bytes(&hw->info, &out->rate,
> +                                 (out->fsize - out->fpos) << 2);
>      return out->frame + out->fpos;
>  }

I am not familiar with this "rate" thing, but you are changing the way
it works for Spice without explaining why, and that worries me a
little.

The rate->bytes_sent is not updated the same way, the result is not
always << 2..

I really don't get what this is really doing tbh, some kind of clever
buffer limit :)



-- 
Marc-André Lureau



reply via email to

[Prev in Thread] Current Thread [Next in Thread]