Re: [Qemu-devel] [PATCH 15/25] paaudio: do not create multiple connections to the same server

[Kővágó Zoltán]

Hi,

2015-08-20 21:38 keltezéssel, Marc-André Lureau írta:
[snip]
> > +    flags =
> > +        PA_STREAM_INTERPOLATE_TIMING
> > +#ifdef PA_STREAM_ADJUST_LATENCY
> > +        |PA_STREAM_ADJUST_LATENCY
> > +#endif
> > +        |PA_STREAM_AUTO_TIMING_UPDATE;
> > +    if (dev) {
> > +        /* don't move the stream if the user specified a sink/source */
> > +        flags |= PA_STREAM_DONT_MOVE;
>
> This is unrelated, and I don't think it's justified, imho user should
> be allowed to move the stream later if needed.

True, I will remove it from this commit.  But not sure if I want to 
remove it completely, because it looks like pulseaudio has a tendency to 
automatically move the stream on connect, even if you explicitly specify 
a sink/source when connecting.  (And the problem is that all streams 
appear under the name qemu in pulseaudio, so once the user moves one 
stream, pulseaudio will assume all streams subsequently created by qemu 
are the same on, and move them too.  Maybe we shold add some extra 
options to the pa backend?)