[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] QEMU produces invalid JSON due to locale-dependent code
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-devel] QEMU produces invalid JSON due to locale-dependent code |
Date: |
Mon, 24 Aug 2015 12:29:21 +0200 |
User-agent: |
Notmuch/0.13.2 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu) |
On Mon 24 Aug 2015 12:05:02 PM CEST, Markus Armbruster wrote:
>> This seems to happen because of GTK+ calling setlocale(). The easiest
>> solution is probably to call setlocale(LC_NUMERIC, "C") before
>> snprintf() (or at start-up ui/gtk.c), but opinions are welcome.
>
> A library calling setlocale() is a big no-no in my book.
>
> Overriding LC_NUMERIC as you propose should fix this particular bug.
>However, exposing unprepared code to locale is not a good idea for
>other categories as well. LC_COLLATE and LC_CTYPE are even sneakier
>sources of bugs in my experience. I'd really, really prefer to stay in
>the "C" locale *completely*.
You can prevent GTK+ from calling setlocale() by using
gtk_disable_setlocale() before gtk_init(), but note that setlocale() is
needed for gettext.
Berto
- [Qemu-devel] QEMU produces invalid JSON due to locale-dependent code, Alberto Garcia, 2015/08/18
- Re: [Qemu-devel] QEMU produces invalid JSON due to locale-dependent code, Daniel P. Berrange, 2015/08/24
- Re: [Qemu-devel] QEMU produces invalid JSON due to locale-dependent code, Markus Armbruster, 2015/08/24
- Re: [Qemu-devel] QEMU produces invalid JSON due to locale-dependent code,
Alberto Garcia <=
- Re: [Qemu-devel] QEMU produces invalid JSON due to locale-dependent code, Markus Armbruster, 2015/08/24
- Re: [Qemu-devel] QEMU produces invalid JSON due to locale-dependent code, Eric Blake, 2015/08/24
- Re: [Qemu-devel] QEMU produces invalid JSON due to locale-dependent code, Markus Armbruster, 2015/08/25
- Re: [Qemu-devel] QEMU produces invalid JSON due to locale-dependent code, Alberto Garcia, 2015/08/25
- Re: [Qemu-devel] QEMU produces invalid JSON due to locale-dependent code, Markus Armbruster, 2015/08/25
- Re: [Qemu-devel] QEMU produces invalid JSON due to locale-dependent code, Alberto Garcia, 2015/08/26
- Re: [Qemu-devel] QEMU produces invalid JSON due to locale-dependent code, Daniel P. Berrange, 2015/08/26
- Re: [Qemu-devel] QEMU produces invalid JSON due to locale-dependent code, Markus Armbruster, 2015/08/26
- Re: [Qemu-devel] QEMU produces invalid JSON due to locale-dependent code, Daniel P. Berrange, 2015/08/24
- Re: [Qemu-devel] QEMU produces invalid JSON due to locale-dependent code, Eric Blake, 2015/08/24