Re: [Qemu-devel] [PATCH v2 00/18] implement vNVDIMM

[Xiao Guangrong]

On 08/26/2015 12:26 AM, Stefan Hajnoczi wrote:
> On Fri, Aug 14, 2015 at 10:51:53PM +0800, Xiao Guangrong wrote:
> > Changlog:
> > - Use litten endian for DSM method, thanks for Stefan's suggestion
> >
> > - introduce a new parameter, @configdata, if it's false, Qemu will
> >    build a static and readonly namespace in memory and use it serveing
> >    for DSM GET_CONFIG_SIZE/GET_CONFIG_DATA requests. In this case, no
> >    reserved region is needed at the end of the @file, it is good for
> >    the user who want to pass whole nvdimm device and make its data
> >    completely be visible to guest
> >
> > - divide the source code into separated files and add maintain info
>
> I have skipped ACPI patches because I'm not very familiar with that
> area.

Thank you very much for your review, your comment is great helpful to
me, Stefan!

> Have you thought about live migration?
>
> Are the contents of the NVDIMM migrated since they are registered as a
> RAM region?

Will fully test live migration and VM save before sending the V3 out. :)