[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 05/12] qga: copy argument strings
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH v3 05/12] qga: copy argument strings |
Date: |
Wed, 26 Aug 2015 20:41:20 +0200 |
On Wed, Aug 26, 2015 at 8:27 PM, Denis V. Lunev <address@hidden> wrote:
> lets consider this patch. You have done 2 things:
> - changed initialisation order and dropped nasty temporary variables
> - introduced alloc/free code
>
> But in the next patch each line with alloc/free code
> will be changed due to variable rename and
> moving to the separate function (free), which
> IMHO means that this preparatory step is unnecessary,
> you will make almost same changes in the next
> patch
to me this patch is a preparatory cleanup, having variable initialized
to NULL, string allocated, and free. The nice side effect is that we
can get rid of the weird fixed_state_dir stuff.
> Thus the sum of changes in this patch/next patch
> would be less with uncovering initialization
> change details, which are missed in the patch
> description
I agree I can complete the commit description, but I think it's best
to keep this preparatory cleanup.
--
Marc-André Lureau
- Re: [Qemu-devel] [PATCH v3 03/12] qga: move string split in separate function, (continued)
[Qemu-devel] [PATCH v3 04/12] qga: rename 'path' to 'channel_path', marcandre . lureau, 2015/08/26
[Qemu-devel] [PATCH v3 05/12] qga: copy argument strings, marcandre . lureau, 2015/08/26
[Qemu-devel] [PATCH v3 06/12] qga: move option parsing to separate function, marcandre . lureau, 2015/08/26
[Qemu-devel] [PATCH v3 07/12] qga: fill default options in main(), marcandre . lureau, 2015/08/26
[Qemu-devel] [PATCH v3 08/12] qga: move agent run in a separate function, marcandre . lureau, 2015/08/26
[Qemu-devel] [PATCH v3 09/12] qga: free a bit more, marcandre . lureau, 2015/08/26
[Qemu-devel] [PATCH v3 10/12] qga: add an optionnal qemu-ga.conf system configuration, marcandre . lureau, 2015/08/26