[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 08/13] qga: fill default options in main()
From: |
marcandre . lureau |
Subject: |
[Qemu-devel] [PATCH v4 08/13] qga: fill default options in main() |
Date: |
Thu, 27 Aug 2015 01:34:54 +0200 |
From: Marc-André Lureau <address@hidden>
Fill all default options during main(). This is a preparation patch
to allow to dump the configuration.
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Michael Roth <address@hidden>
Reviewed-by: Denis V. Lunev <address@hidden>
---
qga/main.c | 34 +++++++++++++++++-----------------
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/qga/main.c b/qga/main.c
index 900b68c..38ee196 100644
--- a/qga/main.c
+++ b/qga/main.c
@@ -658,23 +658,6 @@ static gboolean channel_init(GAState *s, const gchar
*method, const gchar *path)
{
GAChannelMethod channel_method;
- if (method == NULL) {
- method = "virtio-serial";
- }
-
- if (path == NULL) {
- if (strcmp(method, "virtio-serial") == 0 ) {
- /* try the default path for the virtio-serial port */
- path = QGA_VIRTIO_PATH_DEFAULT;
- } else if (strcmp(method, "isa-serial") == 0){
- /* try the default path for the serial port - COM1 */
- path = QGA_SERIAL_PATH_DEFAULT;
- } else {
- g_critical("must specify a path for this channel");
- return false;
- }
- }
-
if (strcmp(method, "virtio-serial") == 0) {
s->virtio = true; /* virtio requires special handling in some cases */
channel_method = GA_CHANNEL_VIRTIO_SERIAL;
@@ -1095,6 +1078,23 @@ int main(int argc, char **argv)
config->state_dir = g_strdup(dfl_pathnames.state_dir);
}
+ if (config->method == NULL) {
+ config->method = g_strdup("virtio-serial");
+ }
+
+ if (config->channel_path == NULL) {
+ if (strcmp(config->method, "virtio-serial") == 0) {
+ /* try the default path for the virtio-serial port */
+ config->channel_path = g_strdup(QGA_VIRTIO_PATH_DEFAULT);
+ } else if (strcmp(config->method, "isa-serial") == 0) {
+ /* try the default path for the serial port - COM1 */
+ config->channel_path = g_strdup(QGA_SERIAL_PATH_DEFAULT);
+ } else {
+ g_critical("must specify a path for this channel");
+ goto out_bad;
+ }
+ }
+
#ifdef _WIN32
/* On win32 the state directory is application specific (be it the default
* or a user override). We got past the command line parsing; let's create
--
2.4.3
- Re: [Qemu-devel] [PATCH v4 03/13] qga: move string split in separate function, (continued)
[Qemu-devel] [PATCH v4 05/13] qga: rename 'path' to 'channel_path', marcandre . lureau, 2015/08/26
[Qemu-devel] [PATCH v4 06/13] qga: copy argument strings, marcandre . lureau, 2015/08/26
[Qemu-devel] [PATCH v4 07/13] qga: move option parsing to separate function, marcandre . lureau, 2015/08/26
[Qemu-devel] [PATCH v4 08/13] qga: fill default options in main(),
marcandre . lureau <=
[Qemu-devel] [PATCH v4 09/13] qga: move agent run in a separate function, marcandre . lureau, 2015/08/26
[Qemu-devel] [PATCH v4 10/13] qga: free a bit more, marcandre . lureau, 2015/08/26
[Qemu-devel] [PATCH v4 11/13] qga: add an optional qemu-ga.conf system configuration, marcandre . lureau, 2015/08/26
[Qemu-devel] [PATCH v4 13/13] qga: start a man page, marcandre . lureau, 2015/08/26
[Qemu-devel] [PATCH v4 12/13] qga: add --dump-conf option, marcandre . lureau, 2015/08/26