Re: [Qemu-devel] Should we auto-generate IDs?

[Eric Blake]

On 08/27/2015 10:06 AM, Daniel P. Berrange wrote:

>>
>> I applied your patch, but saw this error message when I tried to 'make' QEMU:
>>
>>   GEN   qmp-commands.txt
>> line 344: syntax error: expected EQMP, found SQMP
>> make: *** [qmp-commands.txt] Error 1
>> make: *** Deleting file `qmp-commands.txt'
>>
>> Know what it means?
> 
> It means I should have run 'make' again after adding the documentation
> to detect the bug :-) I'll send another patch....

Generally, it's nicer to reply about problems with a patch to the patch
itself, rather than in an unrelated thread.  Makes it easier for
maintainers to see that a v2 of the patch will be needed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature