[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC v4 06/32] qapi: Split up some typedefs to ea
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH RFC v4 06/32] qapi: Split up some typedefs to ease review |
Date: |
Thu, 3 Sep 2015 17:19:54 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, Sep 03, 2015 at 04:29:57PM +0200, Markus Armbruster wrote:
> One of the next patches will among other things generate a separate
> typedef for some struct types, i.e.
>
> typedef struct FOO FOO;
>
> struct FOO {
> ...
> };
>
> instead of
>
> typedef struct FOO {
> ...
> } FOO;
>
> To make the generated files easier to diff, anticipate the change.
>
> Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Daniel P. Berrange <address@hidden>
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
- [Qemu-devel] [PATCH RFC v4 00/32] qapi: QMP introspection, Markus Armbruster, 2015/09/03
- [Qemu-devel] [PATCH RFC v4 01/32] qapi: Rename class QAPISchema to QAPISchemaParser, Markus Armbruster, 2015/09/03
- [Qemu-devel] [PATCH RFC v4 03/32] qapi: QAPISchema code generation helper methods, Markus Armbruster, 2015/09/03
- [Qemu-devel] [PATCH RFC v4 06/32] qapi: Split up some typedefs to ease review, Markus Armbruster, 2015/09/03
- Re: [Qemu-devel] [PATCH RFC v4 06/32] qapi: Split up some typedefs to ease review,
Daniel P. Berrange <=
- [Qemu-devel] [PATCH RFC v4 13/32] qapi: De-duplicate enum code generation, Markus Armbruster, 2015/09/03
- [Qemu-devel] [PATCH RFC v4 18/32] qapi: Replace dirty is_c_ptr() by method c_null(), Markus Armbruster, 2015/09/03
- [Qemu-devel] [PATCH RFC v4 12/32] qapi-commands: Convert to QAPISchemaVisitor, Markus Armbruster, 2015/09/03
- [Qemu-devel] [PATCH RFC v4 09/32] Revert "qapi: Split up some typedefs to ease review", Markus Armbruster, 2015/09/03
- [Qemu-devel] [PATCH RFC v4 15/32] qapi-event: Convert to QAPISchemaVisitor, fixing data with base, Markus Armbruster, 2015/09/03
- [Qemu-devel] [PATCH RFC v4 11/32] qapi-visit: Convert to QAPISchemaVisitor, fixing bugs, Markus Armbruster, 2015/09/03
- [Qemu-devel] [PATCH RFC v4 07/32] qapi: Generate comments to simplify splitting for review, Markus Armbruster, 2015/09/03
- [Qemu-devel] [PATCH RFC v4 04/32] qapi: New QAPISchemaVisitor, Markus Armbruster, 2015/09/03