[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] Add dynamic module loading for block driver
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] Add dynamic module loading for block drivers |
Date: |
Thu, 3 Sep 2015 17:33:16 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Aug 17, 2015 at 10:09:34AM +0200, Marc MarĂ wrote:
> +static const struct {
> + const char *format_name;
> + const char *protocol_name;
> + const char *library_name;
> + bool has_probe;
> + bool has_probe_device;
> +} block_driver_module[] = {
Why is this list incomplete? It doesn't cover all block drivers.
Perhaps these are the only modular block drivers.
Also, it ignores CONFIG_CURL and friends. Perhaps it doesn't matter
because the module loading code will just see that there is no file
there, but maybe conditional compilation should be used?
A plural name would more consistent (i.e. you deleted the
plural block_modules[] variable and introduced a singular
block_driver_module[] variable).
- Re: [Qemu-devel] [PATCH 1/2] Add dynamic module loading for block drivers,
Stefan Hajnoczi <=