Re: [Qemu-devel] [PATCH] virtio dataplane: adapt dataplane for virtio Version 1

[Stefan Hajnoczi]

On Wed, Aug 26, 2015 at 02:55:45PM +0200, Cornelia Huck wrote:
> On Wed, 26 Aug 2015 13:50:52 +0100
> Stefan Hajnoczi <address@hidden> wrote:
> 
> > On Tue, Aug 25, 2015 at 12:33:30PM +0200, Pierre Morel wrote:
> > > -    vring_init(&vring->vr, virtio_queue_get_num(vdev, n), vring_ptr, 
> > > 4096);
> > 
> > vring_init() is no longer used.  Please delete it.
> > 
> 
> vring_init() is defined in a header imported from Linux.

You are right, I was confused.  The grep output shows we have two
vring_init() in QEMU:

include/standard-headers/linux/virtio_ring.h:static inline void 
vring_init(struct vring *vr, unsigned int num, void *p,
pc-bios/s390-ccw/virtio.c:static void vring_init(struct vring *vr, unsigned int 
num, void *p,