Re: [Qemu-devel] [kvm-unit-tests PATCH 2/2] arm/arm64 config: Fix arch_clean rule

[Andrew Jones]

On Wed, Sep 02, 2015 at 11:25:26AM +0200, Alexander Spyridakis wrote:
> Properly clean any generated object and binary files after a 'make clean',
> this fixes an issue when trying to reconfigure between arm and arm64.

Are you also running configure (with the opposite arch selected) after
'make clean'? If not, then that could be the source of your problems.
Anyway, please describe the issues you're seeing because I don't see
what this patch is doing that isn't already being done. The lines this
patch adds are already there. See the arm_clean target in
config/config-arm-common.mak.

Thanks,
drew

> 
> Signed-off-by: Alexander Spyridakis <address@hidden>
> ---
>  config/config-arm.mak   | 2 ++
>  config/config-arm64.mak | 3 ++-
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/config/config-arm.mak b/config/config-arm.mak
> index ae6c2e7..68fab62 100644
> --- a/config/config-arm.mak
> +++ b/config/config-arm.mak
> @@ -21,3 +21,5 @@ tests =
>  include config/config-arm-common.mak
>  
>  arch_clean: arm_clean
> +     $(RM) $(TEST_DIR)/*.o $(TEST_DIR)/*.flat $(TEST_DIR)/*.elf \
> +     $(TEST_DIR)/.*.d lib/arm/.*.d
> diff --git a/config/config-arm64.mak b/config/config-arm64.mak
> index d61b703..a0bc1b3 100644
> --- a/config/config-arm64.mak
> +++ b/config/config-arm64.mak
> @@ -17,4 +17,5 @@ tests =
>  include config/config-arm-common.mak
>  
>  arch_clean: arm_clean
> -     $(RM) lib/arm64/.*.d
> +     $(RM) $(TEST_DIR)/*.o $(TEST_DIR)/*.flat $(TEST_DIR)/*.elf \
> +     $(TEST_DIR)/.*.d lib/arm64/.*.d
> -- 
> 2.1.4
> 
>