[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 10/33] qapi-visit: Replace list implicit_structs by s
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PULL 10/33] qapi-visit: Replace list implicit_structs by set |
Date: |
Fri, 4 Sep 2015 16:21:17 +0200 |
Use set because that's what it is. While there, rename to
implicit_structs_seen.
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
scripts/qapi-visit.py | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/scripts/qapi-visit.py b/scripts/qapi-visit.py
index b3a308f..9fc040e 100644
--- a/scripts/qapi-visit.py
+++ b/scripts/qapi-visit.py
@@ -16,14 +16,13 @@ from ordereddict import OrderedDict
from qapi import *
import re
-implicit_structs = []
+implicit_structs_seen = set()
struct_fields_seen = set()
def generate_visit_implicit_struct(type):
- global implicit_structs
- if type in implicit_structs:
+ if type in implicit_structs_seen:
return ''
- implicit_structs.append(type)
+ implicit_structs_seen.add(type)
ret = ''
if type not in struct_fields_seen:
# Need a forward declaration
--
2.4.3
- [Qemu-devel] [PULL 29/33] tests/qapi-schema: Cover non-string, non-dictionary members, (continued)
- [Qemu-devel] [PULL 29/33] tests/qapi-schema: Cover non-string, non-dictionary members, Markus Armbruster, 2015/09/04
- [Qemu-devel] [PULL 24/33] qapi-commands: Don't feed output of mcgen() to mcgen() again, Markus Armbruster, 2015/09/04
- [Qemu-devel] [PULL 28/33] tests/qapi-schema: Cover two more syntax errors, Markus Armbruster, 2015/09/04
- [Qemu-devel] [PULL 19/33] qapi-tests: New tests for union, alternate command arguments, Markus Armbruster, 2015/09/04
- [Qemu-devel] [PULL 09/33] qapi-visit: Fix generated code when schema has forward refs, Markus Armbruster, 2015/09/04
- [Qemu-devel] [PULL 21/33] qapi: Command returning anonymous type doesn't work, outlaw, Markus Armbruster, 2015/09/04
- [Qemu-devel] [PULL 20/33] qapi: Fix to reject union command and event arguments, Markus Armbruster, 2015/09/04
- [Qemu-devel] [PULL 32/33] docs/qapi-code-gen.txt: Fix QAPI schema examples, Markus Armbruster, 2015/09/04
- [Qemu-devel] [PULL 33/33] qapi: Generators crash when --output-dir isn't given, fix, Markus Armbruster, 2015/09/04
- [Qemu-devel] [PULL 31/33] qapi: Simplify error reporting for array types, Markus Armbruster, 2015/09/04
- [Qemu-devel] [PULL 10/33] qapi-visit: Replace list implicit_structs by set,
Markus Armbruster <=
- [Qemu-devel] [PULL 17/33] tests/qapi-schema: Restore test case for flat union base bug, Markus Armbruster, 2015/09/04
- [Qemu-devel] [PULL 26/33] qapi: Generated code cleanup, Markus Armbruster, 2015/09/04
- [Qemu-devel] [PULL 18/33] tests/qapi-schema: Rename tests from data- to args-, Markus Armbruster, 2015/09/04
- Re: [Qemu-devel] [PULL 00/33] qapi: Another round of fixes and cleanups, Peter Maydell, 2015/09/04