Re: [Qemu-devel] [PATCH v2 05/49] net: use Netdev instead of NetClientOptions in client init

[Eric Blake]

On 08/21/2015 09:37 AM, Kővágó, Zoltán wrote:
> This way we no longer need NetClientOptions and can convert Netdev
> into a flat union.
> 
> Signed-off-by: Kővágó, Zoltán <address@hidden>
> ---
>  net/clients.h    | 20 ++++++++++----------
>  net/dump.c       |  6 +++---
>  net/hub.c        |  6 +++---
>  net/l2tpv3.c     |  6 +++---
>  net/net.c        | 29 ++++++++++++++---------------
>  net/netmap.c     |  4 ++--
>  net/slirp.c      |  6 +++---
>  net/socket.c     |  6 +++---
>  net/tap-win32.c  |  6 +++---
>  net/tap.c        | 12 ++++++------
>  net/vde.c        |  6 +++---
>  net/vhost-user.c |  6 +++---
>  12 files changed, 56 insertions(+), 57 deletions(-)

Nice; you've already done some of the work that I saw as needing to be
done for my plans to convert QMP netdev_add to use a flat union instead
of 'gen':false.

Conflicts with my s/kind/type/ in
https://lists.gnu.org/archive/html/qemu-devel/2015-08/msg02061.html, so
whoever goes in first gets to avoid the obvious merge conflict
resolution.  :)

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature