Re: [Qemu-devel] [PATCH V2] sdhci: use PRIx64 for uint64_t type

[Peter Crosthwaite]

On Sat, Sep 5, 2015 at 2:12 AM, Sai Pavan Boddu
<address@hidden> wrote:
> Fix compile time warnings, because of type mismatch for unsigned long
> long type.
>
> Signed-off-by: Sai Pavan Boddu <address@hidden>

Reviewed-by: Peter Crosthwaite <address@hidden>

> ---
> Changes for V2:
>     Fix commit message.
>     Correct line lenght.
> ---
>  hw/sd/sdhci.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c
> index 2469077..639feee 100644
> --- a/hw/sd/sdhci.c
> +++ b/hw/sd/sdhci.c
> @@ -22,6 +22,7 @@
>   * with this program; if not, see <http://www.gnu.org/licenses/>.
>   */
>
> +#include <inttypes.h>
>  #include "hw/hw.h"
>  #include "sysemu/block-backend.h"
>  #include "sysemu/blockdev.h"
> @@ -719,7 +720,8 @@ static void sdhci_do_adma(SDHCIState *s)
>              break;
>          case SDHC_ADMA_ATTR_ACT_LINK:   /* link to next descriptor table */
>              s->admasysaddr = dscr.addr;
> -            DPRINT_L1("ADMA link: admasysaddr=0x%lx\n", s->admasysaddr);
> +            DPRINT_L1("ADMA link: admasysaddr=0x%" PRIx64 "\n",
> +                      s->admasysaddr);
>              break;
>          default:
>              s->admasysaddr += dscr.incr;
> @@ -727,7 +729,8 @@ static void sdhci_do_adma(SDHCIState *s)
>          }
>
>          if (dscr.attr & SDHC_ADMA_ATTR_INT) {
> -            DPRINT_L1("ADMA interrupt: admasysaddr=0x%lx\n", s->admasysaddr);
> +            DPRINT_L1("ADMA interrupt: admasysaddr=0x%" PRIx64 "\n",
> +                      s->admasysaddr);
>              if (s->norintstsen & SDHC_NISEN_DMA) {
>                  s->norintsts |= SDHC_NIS_DMA;
>              }
> --
> 1.9.1
>