Re: [Qemu-devel] [PATCH 2/4] CODING_STYLE, checkpatch: update line length rules

[Eduardo Habkost]

On Mon, Sep 07, 2015 at 06:06:25PM +0200, Paolo Bonzini wrote:
> On 07/09/2015 17:23, Markus Armbruster wrote:
> > > Apart from copy-n-pasting, there is also the problem that you can run
> > > "checkpatch.pl -f" on a whole file ... it would also be ugly to suddenly
> > > have (much) more warnings here.
> > 
> > Feature.  If you run checkpatch on a whole file, you obviously do it to
> > find its ugly spots.  Lines longer than 76 characters qualify.
> 
> Based on the statistics, half of QEMU's files has at least one 76-79
> character line.  The noise from checkpatch.pl -f is actually a worse
> thing than the cut-and-paste, but that's something that can be fixed in
> other ways (e.g. different strictness for checkpatch.pl vs.
> checkpatch.pl -f).

Why exactly it's considered noise? I fail to see why would somebody use
checkpatch.pl -f if they don't want to see all warnings about the whole
file (including the lines that they didn't write). If somebody doesn't
want to see them, they can simply run checkpatch.pl on the diff instead
of using -f.

-- 
Eduardo