qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/2] tests: add a local test for guest agent


From: Michael Roth
Subject: Re: [Qemu-devel] [PATCH 2/2] tests: add a local test for guest agent
Date: Wed, 09 Sep 2015 12:36:08 -0500
User-agent: alot/0.3.6

Quoting Marc-André Lureau (2015-08-27 06:36:43)
> On Thu, Aug 27, 2015 at 12:52 PM,  <address@hidden> wrote:
> > +    success = success && status == 0 && g_strcmp0(virt_what, virt);
> 
> this is now:
> g_strcmp0(g_strstrip(virt_what), virt) == 0

Just to be sure, is this the change you intended?

diff --git a/tests/test-qga.c b/tests/test-qga.c
index 1fb58ec..ca4bcb5 100644
--- a/tests/test-qga.c
+++ b/tests/test-qga.c
@@ -634,7 +634,8 @@ static gboolean running_in_virt(const gchar *virt)
     success = g_spawn_command_line_sync("virt-what", &virt_what, NULL,
                                         &status, NULL);
 
-    success = success && status == 0 && g_strcmp0(virt_what, virt);
+    success = success && status == 0 &&
+        g_strcmp0(g_strstrip(virt_what), virt) == 0;
 
     g_free(virt_what);

> 
> -- 
> Marc-André Lureau
> 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]