qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag


From: Chen, Tiejun
Subject: Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag
Date: Thu, 10 Sep 2015 09:21:52 +0800
User-agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0

On 9/10/2015 12:10 AM, Stefano Stabellini wrote:
On Wed, 9 Sep 2015, Stefano Stabellini wrote:
On Tue, 8 Sep 2015, Peter Maydell wrote:
> On 8 September 2015 at 18:21, Stefano Stabellini
> <address@hidden> wrote:
> > The following changes since commit 8611280505119e296757a60711a881341603fa5a:
> >
> >   target-microblaze: Use setcond for pcmp* (2015-09-08 08:49:33 +0200)
> >
> > are available in the git repository at:
> >
> >   git://xenbits.xen.org/people/sstabellini/qemu-dm.git 
tags/xen-2015-09-08-tag
> >
> > for you to fetch changes up to ba2250ad148997b1352aba976aac66b55410e7e4:
> >
> >   xen/pt: Use XEN_PT_LOG properly to guard against compiler warnings. 
(2015-09-08 15:21:56 +0000)
> >
> > ----------------------------------------------------------------
> > Xen branch xen-2015-09-08
> >
> > ----------------------------------------------------------------
>
> Hi. I'm afraid this fails to build on OSX (and probably Windows too,
> though that build hasn't run yet):
>
>   CC    i386-softmmu/hw/i386/pci-assign-load-rom.o
> /Users/pm215/src/qemu/hw/i386/pci-assign-load-rom.c:6:10: fatal error:
>       'sys/io.h' file not found
> #include <sys/io.h>
>          ^
>   CC    alpha-softmmu/hw/alpha/pci.o
> 1 error generated.

Tiejun,

this is caused by 33d33242b7d802e6c994f3d56ecba96a66465dc3,
"hw/pci-assign: split pci-assign.c". Could you please double-check
non-Linux builds?

I found another issue introduced by the gfx passthrough series on
Windows:

../hw/pci-host/piix.o: In function `host_pci_config_read':
/root/qemu/hw/pci-host/piix.c:778: undefined reference to `_pread'

It is introduced by:

commit fdb70721ba0496a767137e5505dd27627d19c4a8
Author: Tiejun Chen <address@hidden>
Date:   Wed Jul 15 13:37:43 2015 +0800

     piix: create host bridge to passthrough


You might have to replace the pread call with lseek and read.


This is also surprising to me. Just see xen_host_pci_config_xxxx() inside /hw/xen/xen-host-pci-device.c, there are so many this pread usage(). So I really don't understand what's difference between these two files.

Thanks
Tiejun



reply via email to

[Prev in Thread] Current Thread [Next in Thread]