Re: [Qemu-devel] [PATCH v2 1/2] update Linux headers to 4.2

[Michael S. Tsirkin]

On Wed, Sep 09, 2015 at 06:34:00PM +0200, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  hw/pci/pcie_aer.c                            |   4 +-
>  include/standard-headers/linux/pci_regs.h    | 381 
> ++++++++++++++++++++-------
>  include/standard-headers/linux/virtio_ring.h |   3 +-
>  linux-headers/asm-x86/hyperv.h               |   2 +
>  linux-headers/asm-x86/kvm.h                  |   4 +-
>  scripts/update-linux-headers.sh              |   1 +
>  6 files changed, 294 insertions(+), 101 deletions(-)
> 
> diff --git a/hw/pci/pcie_aer.c b/hw/pci/pcie_aer.c
> index f1847ac..8e4bd56 100644
> --- a/hw/pci/pcie_aer.c
> +++ b/hw/pci/pcie_aer.c
> @@ -827,8 +827,8 @@ typedef struct PCIEAERErrorName {
>   */
>  static const struct PCIEAERErrorName pcie_aer_error_list[] = {
>      {
> -        .name = "TRAIN",
> -        .val = PCI_ERR_UNC_TRAIN,
> +        .name = "UND",
> +        .val = PCI_ERR_UNC_UND,
>          .correctable = false,
>      }, {
>          .name = "DLP",

I think we should drop this entry.
The spec says:

        Undefined – The value read from this bit is
        undefined. In previous versions of this
        specification, this bit was used to indicate a Link
        Training Error. System software must ignore the
        value read from this bit. System software is
        permitted to write any value to this bit.

In other words, this bit should be ignored.


-- 
MST