[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 19/29] xen/pt: Use XEN_PT_LOG properly to guard again
From: |
Stefano Stabellini |
Subject: |
[Qemu-devel] [PULL 19/29] xen/pt: Use XEN_PT_LOG properly to guard against compiler warnings. |
Date: |
Thu, 10 Sep 2015 18:15:51 +0100 |
From: Konrad Rzeszutek Wilk <address@hidden>
If XEN_PT_LOGGING_ENABLED is enabled the XEN_PT_LOG macros start
using the first argument. Which means if within the function there
is only one user of the argument ('d') and XEN_PT_LOGGING_ENABLED
is not set, we get compiler warnings. This is not the case now
but with the "xen/pt: Use xen_host_pci_get_[byte|word] instead of dev.config"
we will hit - so this sync up the function to the rest of them.
Reviewed-by: Stefano Stabellini <address@hidden>
Signed-off-by: Konrad Rzeszutek Wilk <address@hidden>
Signed-off-by: Stefano Stabellini <address@hidden>
---
hw/xen/xen_pt_config_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/xen/xen_pt_config_init.c b/hw/xen/xen_pt_config_init.c
index 56c84e1..7b5e65f 100644
--- a/hw/xen/xen_pt_config_init.c
+++ b/hw/xen/xen_pt_config_init.c
@@ -1434,7 +1434,7 @@ static int
xen_pt_msixctrl_reg_init(XenPCIPassthroughState *s,
reg_field = pci_get_word(d->config + real_offset);
if (reg_field & PCI_MSIX_FLAGS_ENABLE) {
- XEN_PT_LOG(d, "MSIX already enabled, disabling it first\n");
+ XEN_PT_LOG(&s->dev, "MSIX already enabled, disabling it first\n");
xen_host_pci_set_word(&s->real_device, real_offset,
reg_field & ~PCI_MSIX_FLAGS_ENABLE);
}
--
1.7.10.4
- [Qemu-devel] [PULL 25/29] xen/pt: Log xen_host_pci_get/set errors in MSI code., (continued)
- [Qemu-devel] [PULL 25/29] xen/pt: Log xen_host_pci_get/set errors in MSI code., Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 24/29] xen/pt: Log xen_host_pci_get in two init functions, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 18/29] xen/pt/msi: Add the register value when printing logging and error messages, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 23/29] xen/pt: Remove XenPTReg->data field., Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 11/29] xen, gfx passthrough: add opregion mapping, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 15/29] xen/pt: Make xen_pt_msi_set_enable static, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 16/29] xen/pt: xen_host_pci_config_read returns -errno, not -1 on failure, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 27/29] xen/pt: Move bulk of xen_pt_unregister_device in its own routine., Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 20/29] xen/pt: Use xen_host_pci_get_[byte|word] instead of dev.config, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 17/29] xen: use errno instead of rc for xc_domain_add_to_physmap, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 19/29] xen/pt: Use XEN_PT_LOG properly to guard against compiler warnings.,
Stefano Stabellini <=
- [Qemu-devel] [PULL 29/29] xen/pt: Don't slurp wholesale the PCI configuration registers, Stefano Stabellini, 2015/09/10
- Re: [Qemu-devel] [PULL 00/29] xen-2015-09-10-tag, Peter Maydell, 2015/09/10