qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 25/34] linux-user: Restart exit() if signal pend


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH 25/34] linux-user: Restart exit() if signal pending
Date: Fri, 11 Sep 2015 15:36:25 +0100

On 6 September 2015 at 00:57, Timothy E Baldwin
<address@hidden> wrote:
> Without this a signal could vanish on thread exit.
>
> Signed-off-by: Timothy Edward Baldwin <address@hidden>
> ---
>  linux-user/syscall.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 4839154..efe61e3 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -5719,8 +5719,12 @@ abi_long do_syscall(void *cpu_env, int num, abi_long 
> arg1,
>             However in threaded applictions it is used for thread termination,
>             and _exit_group is used for application termination.
>             Do thread termination if we have more then one thread.  */
> -        /* FIXME: This probably breaks if a signal arrives.  We should 
> probably
> -           be disabling signals.  */
> +
> +        if (block_signals()) {
> +            ret = -TARGET_ERESTARTSYS;
> +            break;
> +        }
> +
>          if (CPU_NEXT(first_cpu)) {
>              TaskState *ts;
>

Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]