[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Confused by QOM: /machine/unattached/device[5]/dr-conne
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] Confused by QOM: /machine/unattached/device[5]/dr-connector[255]/fdt |
Date: |
Sat, 12 Sep 2015 20:04:38 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 09/09/2015 10:16 AM, Paolo Bonzini wrote:
>>> Is returning NULL without setting an error okay?
>>>
>>> Should it return qnull() instead? Then the QMP return value would be
>>> JSON null.
>
> JSON null support in QObject is new, it should be the result of
> object_property_get_qobject() or even qmp_output_get_qobject(). Needs
> auditing the code.
Yes, returning QNull rather than NULL seems like the right approach.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature