[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/7] qapi-flattening and preparation of -audiode
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 0/7] qapi-flattening and preparation of -audiodev option |
Date: |
Mon, 14 Sep 2015 14:34:10 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
"Kővágó, Zoltán" <address@hidden> writes:
> As discussed here[1], I'm splitting the qapi related patches from my
> previous -audiodev patch series. These are patches 2--7 and 9 from my
> previous patches. (Patch 1 was merged into -trivial in the meanwhile.)
>
> Please review.
>
> [1]: http://lists.nongnu.org/archive/html/qemu-devel/2015-09/msg01505.html
Ongoing QAPI work has shown that the visitors code is brittle, and we
need to retrofit a proper contract[*].
As discussed before, you're proposing dropping a design assumption of
OptsVisitor. Messing with design assumptions is always scary, but it's
even scarier when the whole edifice built on it has been found brittle
already.
I'm afraid we need retrofit a contract *first*, both to build
understanding on how this sucker is supposed to work (right now nobody
knows), and to hopefully make it more robust.
Your series adds urgency to the job.
[*] http://lists.nongnu.org/archive/html/qemu-devel/2015-09/msg03363.html
- Re: [Qemu-devel] [PATCH 2/7] qapi: convert NumaOptions into a flat union, (continued)
- [Qemu-devel] [PATCH 3/7] net: remove NetLegacy struct, Kővágó, Zoltán, 2015/09/07
- [Qemu-devel] [PATCH 6/7] qapi: reorder NetdevBase and Netdev, Kővágó, Zoltán, 2015/09/07
- [Qemu-devel] [PATCH 4/7] net: use Netdev instead of NetClientOptions in client init, Kővágó, Zoltán, 2015/09/07
- [Qemu-devel] [PATCH 7/7] qapi: support nested structs in OptsVisitor, Kővágó, Zoltán, 2015/09/07
- [Qemu-devel] [PATCH 5/7] qapi: change Netdev into a flat union, Kővágó, Zoltán, 2015/09/07
- Re: [Qemu-devel] [PATCH 0/7] qapi-flattening and preparation of -audiodev option,
Markus Armbruster <=