Re: [Qemu-devel] [PATCH] ui/cocoa.m: remove open dialog code

[Programmingkid]

On Sep 14, 2015, at 11:49 AM, Peter Maydell wrote:

> Oops, I meant to cc Andreas on this but got the address wrong.
> 
> -- PMM
> 
> On 14 September 2015 at 16:43, Peter Maydell <address@hidden> wrote:
>> On 11 September 2015 at 01:49, Programmingkid <address@hidden> wrote:
>>> Remove the open dialog code that runs when no arguments are supplied with
>>> QEMU.
>>> Not everyone needs a hard drive or cdrom to boot their target. A user might
>>> only
>>> need to use their target's bios to do work. With that said, this patch
>>> removes
>>> the unneeded open dialog code.
>>> 
>>> Signed-off-by: John Arbuckle <address@hidden>
>> 
>> I admit to not being much of a fan of this feature of the
>> Cocoa UI, but it has been in QEMU's OSX UI since 2005.

QEMU supported Mac OS 10.3 since that time, but that wasn't enough of a 
reason to keep supporting it.

>> In particular, if you remove it then double-clicking to
>> start QEMU from the Finder won't do anything useful, and
>> you now have to start it from the command line.

What if the user finds working with OpenBIOS useful?
What if the target doesn't support a hard drive?
The automatic open dialog feature does get in my way when I
am working with OpenBIOS. 

>> I agree that it does somewhat assume the x86-centric
>> "just provide a disk image" semantics, but it's not clear
>> to me that the most appropriate way to deal with this is
>> to just rip the dialog box code out entirely.

This code is from a time when the x86 target was the only thing people paid
attention to. If the user forgets to supply any arguments to QEMU, he can 
always just quit QEMU and start again with arguments. 

My configuration selection feature did solve this problem by allowing the user
to load a file with QEMU's arguments inside of it.