Re: [Qemu-devel] [PATCH v2 08/18] nvdimm: init backend memory mapping and config data area

[Xiao Guangrong]

On 09/16/2015 12:07 AM, Paolo Bonzini wrote:
> On 26/08/2015 12:40, Xiao Guangrong wrote:
> > > > +
> > > > +    size = get_file_size(fd);
> > > > +    buf = mmap(NULL, size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0);
> > >
> > > I guess the user will want to choose between MAP_SHARED and MAP_PRIVATE.
> > > This can be added in the future.
> >
> > Good idea, it will allow guest to write data but discards its content
> > after it exits. Will implement O_RDONLY + MAP_PRIVATE in the near future.
>
> FWIW, if Igor's backend/frontend idea is implemented, the choice between
> MAP_SHARED and MAP_PRIVATE should belong in the backend.

Yes. I can not agree with you more! :)