Re: [Qemu-devel] [PATCH v3 37/46] contrib: remove unnecessary strdup()

[Vladimir Sementsov-Ogievskiy]

On 15.09.2015 19:07, address@hidden wrote:
> From: Marc-André Lureau <address@hidden>
>
> getopt() optarg points to argv memory, no need to dup those values,
> fixes small leaks detected by clang-analyzer.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>   contrib/ivshmem-client/main.c | 2 +-
>   contrib/ivshmem-server/main.c | 6 +++---
>   2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/contrib/ivshmem-client/main.c b/contrib/ivshmem-client/main.c
> index 5d85ae7..bd7cbfc 100644
> --- a/contrib/ivshmem-client/main.c
> +++ b/contrib/ivshmem-client/main.c
> @@ -53,7 +53,7 @@ ivshmem_client_parse_args(IvshmemClientArgs *args, int argc, 
> char *argv[])
>               break;
>   
>           case 'S': /* unix_sock_path */
> -            args->unix_sock_path = strdup(optarg);
> +            args->unix_sock_path = optarg;
>               break;
>   
>           default:
> diff --git a/contrib/ivshmem-server/main.c b/contrib/ivshmem-server/main.c
> index cd8d9ed..71e87ea 100644
> --- a/contrib/ivshmem-server/main.c
> +++ b/contrib/ivshmem-server/main.c
> @@ -92,15 +92,15 @@ ivshmem_server_parse_args(IvshmemServerArgs *args, int 
> argc, char *argv[])
>               break;
>   
>           case 'p': /* pid_file */
> -            args->pid_file = strdup(optarg);
> +            args->pid_file = optarg;
>               break;
>   
>           case 'S': /* unix_socket_path */
> -            args->unix_socket_path = strdup(optarg);
> +            args->unix_socket_path = optarg;
>               break;
>   
>           case 'm': /* shm_path */
> -            args->shm_path = strdup(optarg);
> +            args->shm_path = optarg;
>               break;
>   
>           case 'l': /* shm_size */

Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>

--
Best regards,
Vladimir
* now, @virtuozzo.com instead of @parallels.com. Sorry for this inconvenience.